On Tue, Apr 24, 2012 at 01:23:53PM +0200, Andreas Färber wrote: > Am 24.04.2012 12:26, schrieb Amit Shah: > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > >> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > >>> From: Alon Levy <al...@redhat.com> > >>> > >>> guest_connected should be false before guest driver initialization, and > >>> true after, both for multiport aware and non multiport aware drivers. > >>> > >>> Don't set it before the guest_features are available; instead use > >>> set_status which is called by io to VIRTIO_PCI_STATUS with > >>> VIRTIO_CONFIG_S_DRIVER_OK by even older non multiport drivers. > >>> > >>> [Amit: Add comment, tweak summary] > >> > >> Logic also changed fron Alon's patch. Why? > > > > Yes, forgot to mention that here. > > Re "here": FWIW I learnt to add these sort of comments before the new > SoB, i.e. between mst's Acked-by and your Signed-off-by so that it is > clear that he ack'ed the previous version given the logic change. In > this case it's arguably irrelevant since there's only one SoB by you.
Good idea. Note about the original patch - I didn't notice the side effect I didn't put in the commit log, and then I missed Amit's change of my code as well :) > > Andreas > > >>> Signed-off-by: Alon Levy <al...@redhat.com> > >>> Acked-by: Michael S. Tsirkin <m...@redhat.com> > >>> Signed-off-by: Amit Shah <amit.s...@redhat.com> > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >