On Fri, Jan 24, 2025 at 04:45:25PM +0100, David Hildenbrand wrote: > This is a follow-up to [1], implementing it by avoiding the use of > address_space_write_rom() in cpu_memory_rw_debug() completely, and > teaching address_space_write() about debug access instead, the can also > write to ROM. > > The goal is to let GDB via cpu_memory_rw_debug() to also properly write to > MMIO device regions, not just RAM/ROM. > > It's worth noting that other users of address_space_write_rom() are > left unchanged. Maybe hw/core/loader.c and friends could now be converted > to to a debug access via address_space_write() instead? > > Survives a basic gitlab CI build/check. > > [1] https://lore.kernel.org/all/20241220195923.314208-1-...@zabka.it/ > > v1 -> v2: > * Split up "physmem: disallow direct access to RAM DEVICE in > address_space_write_rom()" into 4 patches > > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Peter Xu <pet...@redhat.com> > Cc: Philippe Mathieu-Daudé <phi...@linaro.org> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Alex Bennée <alex.ben...@linaro.org> > Cc: Alex Williamson <alex.william...@redhat.com> > Cc: Eduardo Habkost <edua...@habkost.net> > Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com> > Cc: Elena Ufimtseva <elena.ufimts...@oracle.com> > Cc: Jagannathan Raman <jag.ra...@oracle.com> > Cc: "Dr. David Alan Gilbert" <d...@treblig.org> > Cc: Stefan Zabka <g...@zabka.it> > > David Hildenbrand (7): > physmem: factor out memory_region_is_ram_device() check in > memory_access_is_direct() > physmem: factor out RAM/ROMD check in memory_access_is_direct() > physmem: factor out direct access check into > memory_region_supports_direct_access() > physmem: disallow direct access to RAM DEVICE in > address_space_write_rom() > memory: pass MemTxAttrs to memory_access_is_direct() > hmp: use cpu_get_phys_page_debug() in hmp_gva2gpa() > physmem: teach cpu_memory_rw_debug() to write to more memory regions
David, I think it doesn't apply on master, would you rebase and repost? Stefan, it'll always be good to get an ack from you to show this at least works for you - I'd expect that but an explicit email or Tested-by at the last patch would be great (either this or a new version). Thanks, -- Peter Xu
