On 04/02/2025 19.07, Philippe Mathieu-Daudé wrote:
Update MachineClass::no_sdcard default implicit AUTO
initialization to explicit OFF. This flag is consumed
in system/vl.c::qemu_disable_default_devices(). Use
this place to assert we don't have anymore AUTO state.

In hw/ppc/e500.c we add the ppce500_machine_class_init()
method to initialize once all the inherited classes.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Thomas Huth <th...@redhat.com>
---
...
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 12418094f9d..dc80181ea43 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -467,6 +467,7 @@ static void zynq_machine_class_init(ObjectClass *oc, void 
*data)
      mc->ignore_memory_transaction_failures = true;
      mc->valid_cpu_types = valid_cpu_types;
      mc->default_ram_id = "zynq.ext_ram";
+    mc->no_sdcard = ON_OFF_AUTO_OFF;
      prop = object_class_property_add_str(oc, "boot-mode", NULL,
                                           zynq_set_boot_mode);
      object_class_property_set_description(oc, "boot-mode",

This hunk seems to be wrong since the previous patch already sets no_sdcard to ON here?

 Thomas


Reply via email to