On Tue, Feb 04, 2025 at 10:14:06PM +0100, Kevin Wolf wrote:
> Test that it's possible to migrate a VM that uses an image on shared
> storage through qemu-storage-daemon.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> Acked-by: Fabiano Rosas <faro...@suse.de>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
> ---
> tests/qemu-iotests/tests/qsd-migrate | 140 +++++++++++++++++++++++
> tests/qemu-iotests/tests/qsd-migrate.out | 59 ++++++++++
> 2 files changed, 199 insertions(+)
> create mode 100755 tests/qemu-iotests/tests/qsd-migrate
> create mode 100644 tests/qemu-iotests/tests/qsd-migrate.out
>
> + iotests.log('\nPre-switchover: Reconfigure QSD instances')
> +
> + iotests.log(qsd_src.qmp('blockdev-set-active', {'active': False}))
> +
> + # Reading is okay from both sides while the image is inactive. Note that
> + # the destination may have stale data until it activates the image,
> though.
> + vm_src.hmp_qemu_io('virtio0/virtio-backend', 'read -P 0x11 0 4k',
> + use_log=True, qdev=True)
> + vm_dst.hmp_qemu_io('virtio0/virtio-backend', 'read 0 4k',
> + use_log=True, qdev=True)
Interesting observation about reading from stale caches, but it makes
sense with a bit more thought and doesn't hurt the validity of the
series.
R-b stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
