On 04/27/2012 04:37 AM, Jiri Denemark wrote:
On Wed, Apr 11, 2012 at 23:30:24 +0200, Paolo Bonzini wrote:
Since most property types do not have a parse property now, this was
broken. Fix it by looking at the setter instead.
Signed-off-by: Paolo Bonzini<pbonz...@redhat.com>
---
hw/qdev-monitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index 4783366..0acfc82 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
* for removal. This conditional should be removed along with
* it.
*/
- if (!prop->info->parse) {
+ if (!prop->info->set) {
continue; /* no way to set it, don't show */
}
error_printf("%s.%s=%s\n", driver, prop->name,
@@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts)
}
if (info->bus_info) {
for (prop = info->bus_info->props; prop&& prop->name; prop++) {
- if (!prop->info->parse) {
+ if (!prop->info->set) {
continue; /* no way to set it, don't show */
}
error_printf("%s.%s=%s\n", driver, prop->name,
Oops, this patch (or an equivalent fix) doesn't seem to have been ever
applied,
Yeah, there were a couple problems with the full series. Paolo, can I just
cherry pick this patch?
Regards,
Anthony Liguori
which makes libvirt quite unhappy with current qemu. Bootindex cannot
be used through libvirt, to name just one issue resulting from broken
-device foo,?
Jirka
