+Kirti
+Joao

On 2/13/25 22:45, Alex Williamson wrote:
+
+    /*
+     * Migration support
+     */
+    object_class_property_set_description(klass, /* 5.2 */
+                                          "x-pre-copy-dirty-page-tracking",
+                                          "Disable dirty pages tracking during 
iterative phase");
+    object_class_property_set_description(klass, /* 9.1 */
+                                          "x-device-dirty-page-tracking",
+                                          "Disable device dirty page tracking and 
use container-based dirty page tracking");
These are really debug as well, right?  They just happen to be
migration related debug.

I suppose so. I would rather keep them under the migration topic
and add 'debug' in the comment.

Changes :

  commit bb0990d1740f ("vfio: Change default dirty pages tracking behavior during 
migration")
  commit 30b916778517 ("vfio/common: Allow disabling device dirty page 
tracking")

do not explicitly explain why these properties are useful in any way.

Kirti, Joao, could you ?

Thanks,

C.


Reply via email to