On Thu, 27 Feb 2025 at 16:48, Paolo Bonzini <pbonz...@redhat.com> wrote: > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > rust/hw/char/pl011/src/device.rs | 7 +- > rust/hw/char/pl011/src/lib.rs | 509 +--------------------------- > rust/hw/char/pl011/src/registers.rs | 507 +++++++++++++++++++++++++++ > 3 files changed, 513 insertions(+), 510 deletions(-) > create mode 100644 rust/hw/char/pl011/src/registers.rs
Looking at this patch I'm sorely tempted to suggest significantly trimming down the commentary in these comments: it contains rather more text cut-n-pasted from the PL011 TRM than I'm entirely comfortable with, and much of it is detail that is irrelevant to QEMU. I don't think we should be trying to make it unnecessary for somebody working on the QEMU device models to ever look at the hardware reference manuals. thanks -- PMM
