> On 05/02/2012 01:26 PM, Paolo Bonzini wrote: > >> and everyone should be happy :). I would really like to have as > >> little #ifdef TARGET_S390 code in QEMU. And #ifdef __s390__ is > >> even worse, > >> as it means we won't be able to execise that code path on other > >> architectures. > > True, but how do you exercise that code path with DASD geometry > > on !__s390__? > > If we make things a flag for the guessing code, it should work just > as well with image files, right?
Only when they're not blank. :) I was only thinking of #ifdef __s390__ for the call to HDIO_GETGEO. Paolo
