"Maciej S. Szmigiero" <m...@maciej.szmigiero.name> writes: > From: Peter Xu <pet...@redhat.com> > > The newly introduced device state buffer can be used for either storing > VFIO's read() raw data, but already also possible to store generic device > states. After noticing that device states may not easily provide a max > buffer size (also the fact that RAM MultiFDPages_t after all also want to > have flexibility on managing offset[] array), it may not be a good idea to > stick with union on MultiFDSendData.. as it won't play well with such > flexibility. > > Switch MultiFDSendData to a struct. > > It won't consume a lot more space in reality, after all the real buffers > were already dynamically allocated, so it's so far only about the two > structs (pages, device_state) that will be duplicated, but they're small. > > With this, we can remove the pretty hard to understand alloc size logic. > Because now we can allocate offset[] together with the SendData, and > properly free it when the SendData is freed. > > Signed-off-by: Peter Xu <pet...@redhat.com> > [MSS: Make sure to clear possible device state payload before freeing > MultiFDSendData, remove placeholders for other patches not included] > Signed-off-by: Maciej S. Szmigiero <maciej.szmigi...@oracle.com>
Acked-by: Fabiano Rosas <faro...@suse.de>
