On 3/7/2025 3:52 PM, Zhao Liu wrote:
I didn't know if I would need to wait until this patch is merged into
mainline QEMU. That's why I didn't add my signed-off.
No problem if Xiaoyao is okay with it (copyright of patches need to
honor the original author & signed-off). IMO, if your series is accepted
first, it also helps to reduce the size of the TDX series, and it helps
the subsequent PMU development (like mediated PMU). Conversely, it's
also not a big deal; you can simply rebase and remove this patch at that
time.
Hi Dongli,
Usually, if my TDX series is going to be merged soon, or you think this
series won't be accepted soon before TDX series, you can just mention in
the cover letter that this series has a dependency on other patch.
For the case that your series might be accepted earlier, it's better to
just grab the patches needed by this series from others' series. Just
like what you did here.
Like Zhao mentioned, when you grab a patch from others and post with
your series, you need keep the original patch as is (the unchanged
authorship and signed-off-by chain), in addition to add your
signed-off-by at last in the chain.
Even I'm thinking that my KVM PMU filter should perhaps base on your work.
I will add in v3 and remove "DO NOT MERGE" if the patch isn't in QEMU when
I am sending out v3.
Be sure to add your signed-off-by, which tells you are involved.
Okay.
Thanks,
Zhao
