On 11/3/25 16:49, Corey Minyard wrote:
On Tue, Mar 11, 2025 at 10:20:03AM +0100, Philippe Mathieu-Daudé wrote:
On 11/3/25 08:34, Bernhard Beschow wrote:
Am 7. März 2025 19:18:34 UTC schrieb Bernhard Beschow <shen...@gmail.com>:
Am 4. März 2025 18:53:10 UTC schrieb Bernhard Beschow <shen...@gmail.com>:
Am 23. Februar 2025 11:47:08 UTC schrieb Bernhard Beschow <shen...@gmail.com>:
The implementation just allows Linux to determine date and time.
Signed-off-by: Bernhard Beschow <shen...@gmail.com>
---
MAINTAINERS | 2 +
hw/rtc/rs5c372.c | 236 +++++++++++++++++++++++++++++++++++++
tests/qtest/rs5c372-test.c | 43 +++++++
hw/rtc/Kconfig | 5 +
hw/rtc/meson.build | 1 +
hw/rtc/trace-events | 4 +
tests/qtest/meson.build | 1 +
7 files changed, 292 insertions(+)
create mode 100644 hw/rtc/rs5c372.c
create mode 100644 tests/qtest/rs5c372-test.c
Ping for just this patch. I'd like to have it merged for 10.0.
Ping^2 -- just few days left before soft freeze.
Last ping before the freeze
It would really be nice to have this device model in 10.0 since this would
allow me to use upstream QEMU.
Apparently I2C maintainer wasn't Cc'ed (now is):
Corey Minyard <cminy...@mvista.com> (maintainer:I2C and SMBus)
At a glance patch LGTM, so:
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Well, it's fairly hard to read this way :-). But this looks good. My
only comment is on:
+#define NVRAM_SIZE 0x10
+
+/* Flags definitions */
+#define SECONDS_CH 0x80
+#define HOURS_PM 0x20
+#define CTRL2_24 0x20
Those are fairly generic names; when I see things like that I worry
about conflicting with other generic names that might come into an
include later. Not a huge deal, though.
Acked-by: Corey Minyard <cminy...@mvista.com>
Thank you! Patch queued via my hw-misc tree then.
Regards,
Phil.
