On Wed, Mar 12, 2025 at 10:25:58PM +1000, Nicholas Piggin wrote: > Assets are uniquely identified by human-readable-ish url, so make an > AssetError exception class that prints url with error message. > > A property 'transient' is used to capture whether the client may retry > or try again later, or if it is a serious and likely permanent error. > This is used to retain the existing behaviour of treating HTTP errors > other than 404 as 'transient' and not causing precache step to fail. > Additionally, partial-downloads and stale asset caches that fail to > resolve after the retry limit are now treated as transient and do not > cause precache step to fail. > > For background: The NetBSD archive is, at the time of writing, failing > with short transfer. Retrying the fetch at that position (as wget does) > results in a "503 backend unavailable" error. We would like to get that > error code directly, but I have not found a way to do that with urllib, > so treating the short-copy as a transient failure covers that case (and > seems like a reasonable way to handle it in general). > > Reviewed-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Nicholas Piggin <npig...@gmail.com> > --- > roms/skiboot | 2 +- > tests/functional/qemu_test/asset.py | 43 +++++++++++++++++++---------- > tests/lcitool/libvirt-ci | 2 +- > 3 files changed, 30 insertions(+), 17 deletions(-) > > diff --git a/roms/skiboot b/roms/skiboot > index 24a7eb35966..785a5e3070a 160000 > --- a/roms/skiboot > +++ b/roms/skiboot > @@ -1 +1 @@ > -Subproject commit 24a7eb35966d93455520bc2debdd7954314b638b > +Subproject commit 785a5e3070a86e18521e62fe202b87209de30fa2
> diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci > index 18c4bfe02c4..b6a65806bc9 160000 > --- a/tests/lcitool/libvirt-ci > +++ b/tests/lcitool/libvirt-ci > @@ -1 +1 @@ > -Subproject commit 18c4bfe02c467e5639bf9a687139735ccd7a3fff > +Subproject commit b6a65806bc9b2b56985f5e97c936b77c7e7a99fc Two accidents here, with those removed Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
