On Wed, 12 Mar 2025 19:27:14 +0000 Sid Manning <sidn...@quicinc.com> wrote:
>
> > From: Sid Manning <sidn...@quicinc.com>
> > > From: ltaylorsimp...@gmail.com <ltaylorsimp...@gmail.com>
> > > > From: Brian Cain <bc...@quicinc.com>
> > > >
> > > > +uint32_t hexagon_sreg_read(CPUHexagonState *env, uint32_t reg) {
> > > > + return sreg_read(env, reg);
> > > > +}
> > > > +
> > >
> > > Why not just use sreg_read?
> > [Sid Manning]
> > The usage of this is in gdbstub.c and I don't think the extra layer is
> > needed so
> > it can be removed and the stub updated.
> [Sid Manning]
> OK there is a reason this is like this, sreg_read is declared statically
> above and is not available to the debug stub.
Yeah, and it is also annotated with QEMU_ALWAYS_INLINE. But I think we could
simplify the code by renaming sreg_read to hexagon_sreg_read and making it
non-static/non-inlined.
