Hi, > Hi; Coverity points out some problems in this code > (CID 1593154, 1593157):
I'll send fixes later today. > Do we absolutely need to be operating on a continuously open > filedescriptor here rather than a filename? If we could make > these functions use uv->jsonfile each time then we could use > the glib functions g_file_get_contents() and > g_file_set_contents(), which get all the pesky details of the > error handling right for you. qemu_create() works only once in case libvirt hands us a file handle instead of a filename. take care, Gerd