On 25/03/25 20:17, Cédric Le Goater wrote:
On 3/25/25 12:23, Aditya Gupta wrote:
<...snip...>
+static void pnv_machine_power11_class_init(ObjectClass *oc, void
*data)
+{
+ MachineClass *mc = MACHINE_CLASS(oc);
+ PnvMachineClass *pmc = PNV_MACHINE_CLASS(oc);
+ static const char compat[] = "qemu,powernv11\0ibm,powernv";
+
+ pmc->compat = compat;
+ pmc->compat_size = sizeof(compat);
+ pmc->max_smt_threads = 4;
+ pmc->has_lpar_per_thread = true;
+ pmc->quirk_tb_big_core = true;
+ pmc->dt_power_mgt = pnv_dt_power_mgt;
+
+ machine_class_allow_dynamic_sysbus_dev(mc, TYPE_PNV_PHB);
There was a lot of work done to have dynamic PHBs in the PowerNV
machines. This was to add support in libvirt and this goal was
abandoned when people left. I think we should consider removing
it as it adds unnecessary complexity.
Thanks for telling the history behind it, agreed this is unnecessary,
will remove in v7.
Anyhow,
Reviewed-by: Cédric Le Goater <c...@redhat.com>
Thanks for the tag Cédric !
- Aditya Gupta
Thanks,
C.
