On 1/4/25 12:01, Aditya Gupta wrote:
On 25/03/31 08:41AM, Cédric Le Goater wrote:
On 3/29/25 15:26, Aditya Gupta wrote:
Power8E and Power8NVL variants are not of much use in QEMU now, and not
being maintained either.

Newer skiboot might not be able to boot Power8NVL since skiboot v7.0


It is worth mentioning commit c5424f683ee3 ("Remove support for
POWER8 DD1") too. In fact, I prefer the cover letter section below
for a commit log.

This commit log is not mentioning the introduction of POWERPC_DEPRECATED_CPU.
I suggest adding an extra patch for it.

Got it. Sure will include that mention in patch deprecating 8e/8nvl.


Deprecate the 8E and 8NVL variants.

After deprecation, QEMU will print a warning like below when the
CPU/Chips are used:

      $ ./build/qemu-system-ppc64 -M powernv8 --cpu power8nvl -nographic
      qemu-system-ppc64: warning: CPU model power8nvl_v1.0-powerpc64-cpu is 
deprecated -- CPU is unmaintained.
      ...
      $ ./build/qemu-system-ppc64 -M powernv8 --cpu power8e -nographic
      qemu-system-ppc64: warning: CPU model power8e_v2.1-powerpc64-cpu is 
deprecated -- CPU is unmaintained.
      ...
      $ ./build/qemu-system-ppc64 -M pseries --cpu power8e -nographic
      qemu-system-ppc64: warning: CPU model power8e_v2.1-powerpc64-cpu is 
deprecated -- CPU is unmaintained.
      ...

This is not very useful and it belongs to a patch adding
POWERPC_DEPRECATED_CPU.

Got it.


Also, print '(deprecated)' for deprecated CPUs in 'qemu-system-ppc64
--cpu ?':

      $ ./build/qemu-system-ppc64 --cpu help
        ...
        power8e_v2.1     PVR 004b0201 (deprecated)
        power8e          (alias for power8e_v2.1)
        power8nvl_v1.0   PVR 004c0100 (deprecated)
        power8nvl        (alias for power8nvl_v1.0)
        power8_v2.0      PVR 004d0200
        power8           (alias for power8_v2.0)
        power9_v2.0      PVR 004e1200
        power9_v2.2      PVR 004e1202


ditto.

Got it.


Suggested-by: Cédric Le Goater <c...@kaod.org>
Signed-off-by: Aditya Gupta <adit...@linux.ibm.com>

---


By PowerNV deprecation, you mean Power8E/8NVL CPUs right ?

Like there's no powernv8e machine as such, and powernv8e chip doesn't
have a way to deprecate. I can add a 'deprecation_note' kind of field,
but feel that is unnecessary, as it only gets used when power8e CPU is
used, which will show one deprecation warning already.


Also, we have time : the QEMU 10.1 development phase has not started
and the soft freeze should be around July. No rush needed.

Pre-release period is normally OK to deprecate things (Cc'ing Thomas
in doubt...).

Reply via email to