On 26/03/2025 07:51, Cédric Le Goater wrote:
> Also rename vfio_devices_all_device_dirty_tracking_started() while at
> it and use the prefix 'vfio_container_devices_' for routines simply
> looping over the container's device list.
>
> Signed-off-by: Cédric Le Goater <c...@redhat.com>
Much better name indeed:
Reviewed-by: Joao Martins <joao.m.mart...@oracle.com>
> ---
> include/hw/vfio/vfio-container-base.h | 3 ++-
> hw/vfio/common.c | 2 +-
> hw/vfio/container-base.c | 6 +++---
> hw/vfio/container.c | 2 +-
> 4 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-container-base.h
> b/include/hw/vfio/vfio-container-base.h
> index
> 04c87fe48bed75aa281a13f75a36e345036a9163..d00db365991aabf7fdee0c9306197920d9524ed8
> 100644
> --- a/include/hw/vfio/vfio-container-base.h
> +++ b/include/hw/vfio/vfio-container-base.h
> @@ -89,7 +89,8 @@ void vfio_container_del_section_window(VFIOContainerBase
> *bcontainer,
> MemoryRegionSection *section);
> int vfio_container_set_dirty_page_tracking(VFIOContainerBase *bcontainer,
> bool start, Error **errp);
> -bool vfio_devices_all_dirty_tracking_started(const VFIOContainerBase
> *bcontainer);
> +bool vfio_container_dirty_tracking_is_started(
> + const VFIOContainerBase *bcontainer);
> bool vfio_devices_all_device_dirty_tracking(const VFIOContainerBase
> *bcontainer);
> int vfio_get_dirty_bitmap(const VFIOContainerBase *bcontainer, uint64_t iova,
> uint64_t size, ram_addr_t ram_addr, Error **errp);
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index
> 85dedcbe5933c55c6fc25015d3701aba43b381a4..fae8756ade1f85c29a8567adef87135ee111baba
> 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -56,7 +56,7 @@ static bool vfio_log_sync_needed(const VFIOContainerBase
> *bcontainer)
> {
> VFIODevice *vbasedev;
>
> - if (!vfio_devices_all_dirty_tracking_started(bcontainer)) {
> + if (!vfio_container_dirty_tracking_is_started(bcontainer)) {
> return false;
> }
>
> diff --git a/hw/vfio/container-base.c b/hw/vfio/container-base.c
> index
> 7f11aad339e713ea09123f361425370d87762950..7121f68464b144bc397a3bccc36743b65232273c
> 100644
> --- a/hw/vfio/container-base.c
> +++ b/hw/vfio/container-base.c
> @@ -141,7 +141,7 @@ int
> vfio_container_set_dirty_page_tracking(VFIOContainerBase *bcontainer,
> return ret;
> }
>
> -static bool vfio_devices_all_device_dirty_tracking_started(
> +static bool vfio_container_devices_dirty_tracking_is_started(
> const VFIOContainerBase *bcontainer)
> {
> VFIODevice *vbasedev;
> @@ -155,10 +155,10 @@ static bool
> vfio_devices_all_device_dirty_tracking_started(
> return true;
> }
>
> -bool vfio_devices_all_dirty_tracking_started(
> +bool vfio_container_dirty_tracking_is_started(
> const VFIOContainerBase *bcontainer)
> {
> - return vfio_devices_all_device_dirty_tracking_started(bcontainer) ||
> + return vfio_container_devices_dirty_tracking_is_started(bcontainer) ||
> bcontainer->dirty_pages_started;
> }
>
> diff --git a/hw/vfio/container.c b/hw/vfio/container.c
> index
> 7436388a73a424b11e6bad9ce80b86c3792242dd..e827ae9167b780ec9776ab98974245defb57590d
> 100644
> --- a/hw/vfio/container.c
> +++ b/hw/vfio/container.c
> @@ -137,7 +137,7 @@ static int vfio_legacy_dma_unmap(const VFIOContainerBase
> *bcontainer,
> int ret;
> Error *local_err = NULL;
>
> - if (iotlb && vfio_devices_all_dirty_tracking_started(bcontainer)) {
> + if (iotlb && vfio_container_dirty_tracking_is_started(bcontainer)) {
> if (!vfio_devices_all_device_dirty_tracking(bcontainer) &&
> bcontainer->dirty_pages_supported) {
> return vfio_dma_unmap_bitmap(container, iova, size, iotlb);
