On 26/03/2025 07:51, Cédric Le Goater wrote: > vfio_devices_query_dirty_bitmap() is only used in "container-base.c". > Also, rename to vfio_container_devices_query_dirty_bitmap() to reflect > with the prefix 'vfio_container_devices_' that it simply loops over > the container's device list. > > This rename also frees the vfio_devices_query_dirty_bitmap() name > which we will reuse in the next changes. > > Signed-off-by: Cédric Le Goater <c...@redhat.com>
Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> > --- > include/hw/vfio/vfio-container-base.h | 3 --- > hw/vfio/container-base.c | 6 +++--- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/include/hw/vfio/vfio-container-base.h > b/include/hw/vfio/vfio-container-base.h > index > 8575cdcb587dfe803808d452c7dc6c81241a47cf..1227771dd896b5917366ef578109b0ad92da2375 > 100644 > --- a/include/hw/vfio/vfio-container-base.h > +++ b/include/hw/vfio/vfio-container-base.h > @@ -93,9 +93,6 @@ int vfio_container_query_dirty_bitmap(const > VFIOContainerBase *bcontainer, > VFIOBitmap *vbmap, hwaddr iova, hwaddr size, Error > **errp); > bool vfio_devices_all_dirty_tracking_started(const VFIOContainerBase > *bcontainer); > bool vfio_devices_all_device_dirty_tracking(const VFIOContainerBase > *bcontainer); > -int vfio_devices_query_dirty_bitmap(const VFIOContainerBase *bcontainer, > - VFIOBitmap *vbmap, hwaddr iova, hwaddr > size, > - Error **errp); > int vfio_get_dirty_bitmap(const VFIOContainerBase *bcontainer, uint64_t iova, > uint64_t size, ram_addr_t ram_addr, Error **errp); > > diff --git a/hw/vfio/container-base.c b/hw/vfio/container-base.c > index > 2844c5325efffade43022bfb517a43ac372c4125..4edbd39185375dee42ee6e6410da7b94635b5ab8 > 100644 > --- a/hw/vfio/container-base.c > +++ b/hw/vfio/container-base.c > @@ -214,7 +214,7 @@ static int vfio_device_dma_logging_report(VFIODevice > *vbasedev, hwaddr iova, > return 0; > } > > -int vfio_devices_query_dirty_bitmap(const VFIOContainerBase *bcontainer, > +static int vfio_container_devices_query_dirty_bitmap(const VFIOContainerBase > *bcontainer, > VFIOBitmap *vbmap, hwaddr iova, hwaddr size, Error **errp) > { > VFIODevice *vbasedev; > @@ -260,8 +260,8 @@ int vfio_get_dirty_bitmap(const VFIOContainerBase > *bcontainer, uint64_t iova, > } > > if (all_device_dirty_tracking) { > - ret = vfio_devices_query_dirty_bitmap(bcontainer, &vbmap, iova, size, > - errp); > + ret = vfio_container_devices_query_dirty_bitmap(bcontainer, &vbmap, > iova, size, > + errp); > } else { > ret = vfio_container_query_dirty_bitmap(bcontainer, &vbmap, iova, > size, > errp);