On 4/8/25 22:14, Joel Granados wrote:
Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary
for nix environments as they only provide /usr/bin/env at the standard
location.

I am confused, how does this not break everything else? All the test scripts in tests/docker/test-* have "#!/bin/bash", and configure has "/bin/sh". How is the environment that runs scripts/archive-source.sh different, and why should it be fixed in scripts/archive-source.sh?

These are genuine questions - it would help if the commit message explained those... In fact, what is a nix overlay and why would you use scripts/archive-source.sh to prepare one? :)


Signed-off-by: Joel Granados <joel.grana...@kernel.org>
---
  scripts/archive-source.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh
index 
30677c3ec9032ea01090f74602d839d1c571d012..a469a5e2dec4b05e51474f0a1af190c1ccf23c7e
 100755
--- a/scripts/archive-source.sh
+++ b/scripts/archive-source.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
  #
  # Author: Fam Zheng <f...@redhat.com>
  #



Reply via email to