On 10/4/25 18:22, Vladimir Sementsov-Ogievskiy wrote:
Merge qtest_init_with_env_and_capabilities() and qtest_init_with_env()
into one qtest_init_ext().

Reasons:

1. qtest_init_with_env() is just wrong: it gets do_connect parameter
    but always pass true to qtest_init_with_env_and_capabilities().
    Happily, all qtest_init_with_env() callers pass true as well.

2. qtest_init_with_env() is not used outside of libqtest.c, so no
    reason to keep it as public function

3. and in libqtest.c it's used not often, so no problem to use
    more generic function instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
---
  tests/qtest/libqtest.c            | 18 +++++-------------
  tests/qtest/libqtest.h            | 30 +++++++-----------------------
  tests/qtest/migration/framework.c |  7 +++----
  3 files changed, 15 insertions(+), 40 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to