Il 09/05/2012 14:22, Kevin Wolf ha scritto: > Am 08.05.2012 16:51, schrieb Paolo Bonzini: >> We are reusing bs->file across close/open, which may not cause any >> known bugs but is a recipe for trouble. Prefer bdrv_delete, and >> enjoy the new invariant in the implementation of bdrv_delete. >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > I think bs->file is changed during bdrv_open() for all block drivers > that make use of it. We do however leak the old bs->file then.
Right, bdrv_open_common has bs->file = NULL. See also patch 9 in the series... Paolo
