Re: [PATCH 4/8] target/ppc: Evaluate TARGET_BIG_ENDIAN at compile time

[Richard Henderson]

On 4/17/25 06:10, Philippe Mathieu-Daudé wrote:

  static inline bool needs_byteswap(const CPUPPCState *env)
  {
-#if TARGET_BIG_ENDIAN
-  return FIELD_EX64(env->msr, MSR, LE);
-#else
-  return !FIELD_EX64(env->msr, MSR, LE);
-#endif
+  return TARGET_BIG_ENDIAN ^ FIELD_EX64(env->msr, MSR, LE);
  }

This is wrong.  You wanted

   !TARGET_BIG_ENDIAN ^ ...

Likewise in the other instance in translate.c.


r~