On 24/04/2025 10:46, Philippe Mathieu-Daudé wrote:
"accel/tcg/getpc.h" is pulled in indirectly. Include it explicitly to avoid when refactoring unrelated headers:target/riscv/csr.c:2117:25: error: call to undeclared function 'GETPC' [-Wimplicit-function-declaration] 2117 | if ((val & RVC) && (GETPC() & ~3) != 0) { | ^ Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> --- target/riscv/csr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index c52c87faaea..13086438552 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -28,6 +28,7 @@ #include "exec/cputlb.h" #include "exec/tb-flush.h" #include "exec/icount.h" +#include "accel/tcg/getpc.h" #include "qemu/guest-random.h" #include "qapi/error.h" #include <stdbool.h>
I'm mildly curious as to why the target needs to include accel/tcg/getpc.h directly as it's almost a requirement for TCG, but sure:
Reviewed-by: Mark Cave-Ayland <mark.caveayl...@nutanix.com> ATB, Mark.
