Re: [PATCH v4 2/8] vnc: initialize gst during argument processing

[Marc-André Lureau]

Hi

On Mon, Apr 28, 2025 at 12:04 PM Dietmar Maurer <diet...@proxmox.com> wrote:
>
> So that we can set --gst- options on the qemu command line.
>
> Signed-off-by: Dietmar Maurer <diet...@proxmox.com>

This breaks the build, because gstreamer may not be linked.

Maybe another reason to drop the gst_init(argc, argv) and do it in VNC
module only instead...

thanks

> ---
>  system/vl.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/system/vl.c b/system/vl.c
> index ec93988a03..c7fff02da2 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -140,6 +140,10 @@
>  #include "qemu/guest-random.h"
>  #include "qemu/keyval.h"
>
> +#ifdef CONFIG_GSTREAMER
> +#include <gst/gst.h>
> +#endif
> +
>  #define MAX_VIRTIO_CONSOLES 1
>
>  typedef struct BlockdevOptionsQueueEntry {
> @@ -2848,6 +2852,10 @@ void qemu_init(int argc, char **argv)
>      bool userconfig = true;
>      FILE *vmstate_dump_file = NULL;
>
> +#ifdef CONFIG_GSTREAMER
> +    gst_init(&argc, &argv);
> +#endif
> +
>      qemu_add_opts(&qemu_drive_opts);
>      qemu_add_drive_opts(&qemu_legacy_drive_opts);
>      qemu_add_drive_opts(&qemu_common_drive_opts);
> --
> 2.39.5
>
>


-- 
Marc-André Lureau