Re: [PATCH 07/10] accel/tcg: Return TCGTBCPUState from cpu_get_tb_cpu_state

[Pierrick Bouvier]

On 4/28/25 1:10 PM, Richard Henderson wrote:

diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h
index f5e5746976..8dbe79ea7c 100644
--- a/include/accel/tcg/cpu-ops.h
+++ b/include/accel/tcg/cpu-ops.h
@@ -18,8 +18,13 @@
  #include "exec/vaddr.h"
  #include "tcg/tcg-mo.h"

-void cpu_get_tb_cpu_state(CPUArchState *env, vaddr *pc,

-                          uint64_t *cs_base, uint32_t *flags);
+struct TCGTBCPUState {
+    vaddr pc;
+    uint32_t flags;
+    uint64_t flags2;

Could it be named cs_base instead?
flags2 is a little bit generic.

+};

Else,
Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>