Gerd Hoffmann wrote:
> anyone can explain what checkpatch tries to tell me here?
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #11: FILE: hw/usb/hcd-ehci.c:1398:
> +static int ehci_execute(EHCIPacket *p)
Hi Gerd,
When I add that line to that file, creating the patch below,
checkpatch does not complain (Fedora 17's perl):
$ git fp --stdout -1 > k
$ scripts/checkpatch.pl k
total: 0 errors, 0 warnings, 11 lines checked
k has no obvious style problems and is ready for submission.
Regardless, maybe you can placate it by adding a "struct" before
the typedef's EHCIPacket.
>From 49f786191ab2a8176eb44a78e3d5ba44da6e10b6 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@redhat.com>
Date: Thu, 10 May 2012 18:25:51 +0200
Subject: [PATCH] .
Signed-off-by: Jim Meyering <meyer...@redhat.com>
---
hw/usb/hcd-ehci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 4ff4d40..c9ccce9 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2315,6 +2315,11 @@ static void ehci_register_types(void)
type_register_static(&ich9_ehci_info);
}
+static int ehci_execute(EHCIPacket *p)
+{
+}
+
+
type_init(ehci_register_types)
/*
--
1.7.10.1.487.ga3935e6
