On Thu, 1 May 2025, Philippe Mathieu-Daudé wrote:
On 1/5/25 20:34, Bernhard Beschow wrote:
The DEFINE_TYPES() macro doesn't need the qemu/module.h include.
Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using
DEFINE_TYPES() macro")
The 'Fixes:' tag is for bug being fixed. Here I suggest:
Wasn't that Resolves: that's used for bugs or Buglink: and Fixes: to
refer to commits this fixes up? I thought we used Fixes: like that until
now.
Regards,
BALATON Zoltan
Since commit 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM
types using DEFINE_TYPES() macro") which removed the type_init() use,
we don't need to include "qemu/module.h" anymore.
(I can do the update when applying if you agree).
Signed-off-by: Bernhard Beschow <shen...@gmail.com>
---
hw/pci-host/designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
index 183f838392..b4bff14579 100644
--- a/hw/pci-host/designware.c
+++ b/hw/pci-host/designware.c
@@ -20,7 +20,6 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "qemu/module.h"
#include "qemu/log.h"
#include "qemu/bitops.h"
#include "hw/pci/msi.h"
$ git grep -L type_init $(git grep -l qemu/module.h hw) | wc -l
50
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
