On Thu, 1 May 2025 at 20:02, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 1/5/25 20:34, Bernhard Beschow wrote: > > The DEFINE_TYPES() macro doesn't need the qemu/module.h include. > > > > Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using > > DEFINE_TYPES() macro") > > The 'Fixes:' tag is for bug being fixed.
No, Fixes: is for indicating the commit being fixed, so this commit message is fine. We use Resolves: for gitlab bug URLs (though gitlab itself will parse a URL out of a Fixes: tag too). We mention this in https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message with an example of use. thanks -- PMM