On Mon, May 05, 2025 at 10:22:36PM +0000, Joe Komlodi wrote: > address_space_write_rom_internal can take in a NULL pointer for ptr if > it's only doing cache flushes instead of populating the ROM. > > However, if building with --enable-ubsan, incrementing buf causes ubsan > to go off when doing cache flushes, since it will trigger on pointer > arithmetic on a NULL pointer, even if that NULL pointer doesn't get > dereferenced. > > To fix this, we can move the buf incrementing to only be done when > writing data to ROM, since that's the only point where it gets > dereferenced and should be non-NULL. > > Found by running: > qemu-system-aarch64 \ > -machine virt \ > -accel kvm > > When built with --enable-ubsan. > > Signed-off-by: Joe Komlodi <koml...@google.com>
queued, thanks. -- Peter Xu
