On Mon, May 5, 2025 at 8:19 AM Akihiko Odaki <akihiko.od...@daynix.com>
wrote:

> sphinx 5.3.0 fails with Python 3.13.1:
>
> ../docs/meson.build:37: WARNING:
> /home/me/qemu/build/pyvenv/bin/sphinx-build:
> Extension error:
> Could not import extension sphinx.builders.epub3 (exception: No module
> named 'imghdr')
>
> ../docs/meson.build:39:6: ERROR: Problem encountered: Install a Python 3
> version of python-sphinx and the readthedoc theme
>
> Bump sphinx to 8.2.3 and also sphinx_rtd_theme as required for the new
> sphinx version.
>
> Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
> ---
>  docs/requirements.txt | 4 ++--
>  pythondeps.toml       | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/requirements.txt b/docs/requirements.txt
> index 02583f209aa6..50148c99cbd9 100644
> --- a/docs/requirements.txt
> +++ b/docs/requirements.txt
> @@ -1,5 +1,5 @@
>  # Used by readthedocs.io
>  # Should be in sync with the "installed" key of pythondeps.toml
>
> -sphinx==5.3.0
> -sphinx_rtd_theme==1.1.1
> +sphinx==8.2.3
> +sphinx_rtd_theme==3.0.2
>
diff --git a/pythondeps.toml b/pythondeps.toml
> index c03c9df81b5c..4c0da288be6c 100644
> --- a/pythondeps.toml
> +++ b/pythondeps.toml
> @@ -24,8 +24,8 @@ pycotap = { accepted = ">=1.1.0", installed = "1.3.1" }
>
>  [docs]
>  # Please keep the installed versions in sync with docs/requirements.txt
> -sphinx = { accepted = ">=3.4.3", installed = "5.3.0", canary =
> "sphinx-build" }
> -sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.1.1" }
> +sphinx = { accepted = ">=3.4.3", installed = "8.1.3", canary =
> "sphinx-build" }
> +sphinx_rtd_theme = { accepted = ">=0.5", installed = "3.0.2" }
>

Can we set our suggested version to 6.2.0 instead? This version removed
reliance on 'imghdr' but merely requires Python 3.8+ which is our current
stated minimum.

If Thomas upgrades our minimum Python to 3.9, then we could use something
as new as 7.2.0 which requires 3.9+.

I'd say 8.0.0 is too new (requires 3.10+) and conflicts with our stated
minimums.


>
>  [avocado]
>  # Note that qemu.git/python/ is always implicitly installed.
>
> --
> 2.49.0
>
>

Reply via email to