On Fri, May 02, 2025 at 08:56:38PM +0200, Philippe Mathieu-Daudé wrote: > Date: Fri, 2 May 2025 20:56:38 +0200 > From: Philippe Mathieu-Daudé <phi...@linaro.org> > Subject: [PATCH v3 06/19] hw/nvram/fw_cfg: Remove > fw_cfg_io_properties::dma_enabled > X-Mailer: git-send-email 2.47.1 > > Now than all calls to fw_cfg_init_io_dma() pass DMA arguments, > the 'dma_enabled' of the TYPE_FW_CFG_IO type is not used anymore. > Remove it, simplifying fw_cfg_init_io_dma() and fw_cfg_io_realize(). > > Note, we can not remove the equivalent in fw_cfg_mem_properties[] > because it is still used in HPPA and MIPS Loongson3 machines: > > $ git grep -w fw_cfg_init_mem > hw/hppa/machine.c:204: fw_cfg = fw_cfg_init_mem(addr, addr + 4); > hw/mips/loongson3_virt.c:289: fw_cfg = fw_cfg_init_mem(cfg_addr, > cfg_addr + 8, 8);
The argument here is wrong. :-) > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > hw/nvram/fw_cfg.c | 26 ++++++++------------------ > 1 file changed, 8 insertions(+), 18 deletions(-) Reviewed-by: Zhao Liu <zhao1....@intel.com>
