On 5/7/25 1:44 PM, Philippe Mathieu-Daudé wrote:
Since commit d5bd8d8267e ("hvf: only update sysreg from owning thread") hvf-all.c accesses the run_on_cpu_data type and calls run_on_cpu(), both defined in the "hw/core/cpu.h" header. Fortunately, it is indirectly included via:"system/hvf.h" -> "target/arm/cpu.h" -> "target/arm/cpu-qom.h" -> "hw/core/cpu.h" "system/hvf.h" however doesn't need "target/arm/cpu.h" and we want to remove it there. In order to do that we first need to include it in the hvf-all.c file. Cc: Mads Ynddal <m.ynd...@samsung.com> Reported-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> --- accel/hvf/hvf-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 3fc65d6b231..8c387fda24d 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -12,6 +12,7 @@ #include "qemu/error-report.h" #include "system/hvf.h" #include "system/hvf_int.h" +#include "hw/core/cpu.h"const char *hvf_return_string(hv_return_t ret){
Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
