On Thu, Apr 24, 2025 at 07:52:10PM -0500, Eric Blake wrote: > Prove that blockdev-mirror can now result in sparse raw destination > files, regardless of whether the source is raw or qcow2. By making > this a separate test, it was possible to test effects of individual > patches for the various pieces that all have to work together for a > sparse mirror to be successful. > > Note that ./check -file produces different job lengths than ./check > -qcow2 (the test uses a filter to normalize); that's because when > deciding how much of the image to be mirrored, the code looks at how > much of the source image was allocated (for qcow2, this is only the > written clusters; for raw, it is the entire file). But the important > part is that the destination file ends up smaller than 3M, rather than > the 20M it used to be before this patch series. >
> + > +filter_len() { > + sed -e 's/"len": [0-9]*/"len": LEN/g' \ > + -e 's/"offset": [0-9]*/"offset": OFFSET/g' > +} This duplicates _filter_block_job_offset and _filter_block_job_len in common.filter. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org