On 2025/05/06 21:57, Alex Bennée wrote:
From: Dongwon Kim <dongwon....@intel.com>

This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2
which causes some guest display corruption when gtk-gl-area
is used for GTK rendering (e.g. Wayland Compositor) possibly due to
simulataneous accesses on the guest frame buffer by host compositor
and the guest.

Simply reverting the part of the commit may re-introduce the problem the commit tried to solve, which will be a regression as the commit is already included in releases.

I guess the problem is that the gl_block callback of GraphicHwOps is not properly implemented and it is what should be fixed.


Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle")
Reported-by: Dmitry Osipenko <dmitry.osipe...@collabora.com>
Reported-by: Alex Bennée <alex.ben...@linaro.org>
Tested-by: Alex Bennée <alex.ben...@linaro.org>
Tested-by: Dmitry Osipenko <dmitry.osipe...@collabora.com>
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
Reviewed-by: Dmitry Osipenko <dmitry.osipe...@collabora.com>
Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
Cc: Vivek Kasireddy <vivek.kasire...@intel.com>
Signed-off-by: Dongwon Kim <dongwon....@intel.com>
Message-Id: <20250214170813.2234754-1-dongwon....@intel.com>
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
---
  ui/gtk-gl-area.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 2c9a0db425..9f7dc697f2 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -129,7 +129,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)
if (vc->gfx.guest_fb.dmabuf &&
          qemu_dmabuf_get_draw_submitted(vc->gfx.guest_fb.dmabuf)) {
-        gd_gl_area_draw(vc);
          return;
      }


Reply via email to