On 9/5/25 15:30, Thomas Huth wrote:
On 06/05/2025 16.38, Philippe Mathieu-Daudé wrote:
(series reviewed)
Since v2:
- Removed qtest in test-x86-cpuid-compat.c
Since v1:
- Fixed issues noticed by Thomas
The versioned 'pc' and 'q35' machines up to 2.12 been marked
as deprecated two releases ago, and are older than 6 years,
so according to our support policy we can remove them.
This series only includes the 2.4 and 2.5 machines removal,
as it is a big enough number of LoC removed. Rest will
follow. Highlight is the legacy fw_cfg API removal :)
Hi Philippe,
I just gave this series a try, but it fails in at least two spots.
First, you missed this:
diff --git a/hw/block/fdc-isa.c b/hw/block/fdc-isa.c
--- a/hw/block/fdc-isa.c
+++ b/hw/block/fdc-isa.c
@@ -112,7 +112,6 @@ static void isabus_fdc_realize(DeviceState *dev,
Error **errp)
}
qdev_set_legacy_instance_id(dev, isa->iobase, 2);
- qdev_prop_set_enum(dev, "fallback", FLOPPY_DRIVE_TYPE_288);
This should be:
+ fdctrl->fallback = FLOPPY_DRIVE_TYPE_288;
fdctrl_realize_common(dev, fdctrl, &err);
if (err != NULL) {
Second, bios-tables-test now complains about a mismatch in the ACPI
tables somewhere...
I can not reproduce that (tested on macOS and Linux).
Could you please fix that up and check in the gitlab CI whether the
problems are gone? Thanks!
Thomas
