On Mon, May 12, 2025 at 12:35 PM Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > Hi Paolo, > > On 12/5/25 11:52, Paolo Bonzini wrote: > > Unlike other uses of .instance_post_init, accel_cpu_instance_init() > > *registers* properties, and therefore must be run before > > device_post_init() which sets them to their values from -global. > > Does x86_cpu_post_initfn() suffer from the same problem?
No, in fact this whole patch series is motivated by fixing a bug in target/i386: target/i386 *wants* the order of instance_post_init to be what patch 26 provides. This info was present in the postings up to v3, see for example https://patchew.org/QEMU/20250228102747.867770-1-pbonz...@redhat.com/. Paolo > > In order to move all registration of properties to .instance_init, > > call accel_cpu_instance_init() at the end of riscv_cpu_init(). > > > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > --- > > target/riscv/cpu.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) >
