On Fri, 2 May 2025 at 04:31, Nicholas Piggin <npig...@gmail.com> wrote:
>
> Prepare to use some of these constants in xhci qtest code.
This commit is doing more than it says in the commit message.
It also:
* renames some of the constants (mostly prepending XHCI_)
* adds new constants, e.g. for the register offsets and
for some shift amounts, where the original code used
hardcoded values
* makes at least one actual code logic change:
> - case 0x10: /* HCCPARAMS */
> - if (sizeof(dma_addr_t) == 4) {
> - ret = 0x00080000 | (xhci->max_pstreams_mask << 12);
> - } else {
> - ret = 0x00080001 | (xhci->max_pstreams_mask << 12);
> + case XHCI_HCCAP_REG_HCCPARAMS1:
> + ret = (XHCI_HCCAP_EXTCAP_START / 4) << XHCI_HCCPARAMS1_XECP_SHIFT;
> + ret |= xhci->max_pstreams_mask << XHCI_HCCPARAMS1_MAXPSASIZE_SHIFT;
> + if (sizeof(dma_addr_t) == 8) {
> + ret |= XHCI_HCCPARAMS1_AC64;
> }
> break;
It's really tricky to review when you have a single
big patch like this that does more than a simple
mechanical transformation. Could you split it up, please?
thanks
-- PMM
