On Fri, May 09, 2025 at 03:40:26PM -0500, Eric Blake wrote:
> The two callers to a mirror job (drive-mirror and blockdev-mirror) set
> zero_target precisely when sync mode == FULL, with the one exception
> that drive-mirror skips zeroing the target if it was newly created and
> reads as zero.  But given the previous patch, that exception is
> equally captured by target_is_zero.  And since we recently updated
> things to pass the sync mode all the way through to
> mirror_dirty_init(), we can now reconstruct the same conditionals
> without the redundant parameter.
> 
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> 
> ---
> 
> v4: new patch
> ---
>  include/block/block_int-global-state.h |  3 +--
>  block/mirror.c                         | 13 +++++--------
>  blockdev.c                             | 15 ++++-----------
>  tests/unit/test-block-iothread.c       |  2 +-
>  4 files changed, 11 insertions(+), 22 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Attachment: signature.asc
Description: PGP signature

Reply via email to