On Mon, May 12, 2025 at 6:11 PM Michael Tokarev <m...@tls.msk.ru> wrote:
>
> On 05.04.2025 11:04, Akihiko Odaki wrote:
> > The goal of commit 7987d2be5a8b ("virtio-net: Copy received header to
> > buffer") was to remove the need to patch the (const) input buffer with a
> > recomputed UDP checksum by copying headers to a RW region and inject the
> > checksum there. The patch computed the checksum only from the header
> > fields (missing the rest of the payload) producing an invalid one
> > and making guests fail to acquire a DHCP lease.
> >
> > Fix the issue by copying the entire packet instead of only copying the
> > headers.
> >
> > Fixes: 7987d2be5a8b ("virtio-net: Copy received header to buffer")
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2727
> > Cc: qemu-sta...@nongnu.org
> > Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
>
> Ping? Is this change still needed?
Yes, Michael asked for more details for the problem solved here. So
I'd expect there would be a respin here.
https://patchew.org/QEMU/20250424-reapply-v2-1-d0ba763ac...@daynix.com/
Thanks
>
> Thanks,
>
> /mjt
>
