On 05/14/2012 08:56 AM, Michael Roth wrote: > From: Luiz Capitulino <lcapitul...@redhat.com> > > Last commit dropped qemu-ga's SIGCHLD handler, used to automatically > reap terminated children processes. This introduced a bug to > qmp_guest_shutdown(): it will generate zombies. > > This problem probably doesn't matter in the success case, as the VM > will shutdown anyway, but let's do the right thing and reap the > created process. This ultimately means that guest-shutdown is now a > synchronous command. > > An interesting side effect is that guest-shutdown is now able to > report an error to the client if shutting down fails. > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com> > --- > qga/commands-posix.c | 21 ++++++++++++++++----- > 1 files changed, 16 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature