On Mon May 12, 2025 at 1:10 PM AEST, Nicholas Piggin wrote:
> From: Glenn Miles <mil...@linux.ibm.com>
>
> Change pregs to pool_regs, for clarity.
>
Reviewed-by: Nicholas Piggin <npig...@gmail.com>
> [npiggin: split from larger patch]
> Signed-off-by: Glenn Miles <mil...@linux.ibm.com>
> ---
> hw/intc/xive2.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
> index 968b698677..ec4b9320b4 100644
> --- a/hw/intc/xive2.c
> +++ b/hw/intc/xive2.c
> @@ -1044,13 +1044,12 @@ again:
>
> /* PHYS updates also depend on POOL values */
> if (ring == TM_QW3_HV_PHYS) {
> - uint8_t *pregs = &tctx->regs[TM_QW2_HV_POOL];
> + uint8_t *pool_regs = &tctx->regs[TM_QW2_HV_POOL];
>
> /* POOL values only matter if POOL ctx is valid */
> - if (pregs[TM_WORD2] & 0x80) {
> -
> - uint8_t pool_pipr = xive_ipb_to_pipr(pregs[TM_IPB]);
> - uint8_t pool_lsmfb = pregs[TM_LSMFB];
> + if (pool_regs[TM_WORD2] & 0x80) {
> + uint8_t pool_pipr = xive_ipb_to_pipr(pool_regs[TM_IPB]);
> + uint8_t pool_lsmfb = pool_regs[TM_LSMFB];
>
> /*
> * Determine highest priority interrupt and
> @@ -1064,7 +1063,7 @@ again:
> }
>
> /* Values needed for group priority calculation */
> - if (pregs[TM_LGS] && (pool_lsmfb < lsmfb_min)) {
> + if (pool_regs[TM_LGS] && (pool_lsmfb < lsmfb_min)) {
> group_enabled = true;
> lsmfb_min = pool_lsmfb;
> if (lsmfb_min < pipr_min) {
