On 2025/4/1 下午9:48, Igor Mammedov wrote:
On Fri, 28 Feb 2025 17:27:27 +0800
Bibo Mao <maob...@loongson.cn> wrote:

Add empty acpi table for LoongArch64 virt machine, it is only empty
file and there is no data in these files.

this patch after 3/6 doesn't make sense,
either drop.
Empty acpi table can be dropped.

Adding empty blobs, can be useful (as then you can get ACPI diff during test)
but only if you follow update acpi blos process as described in
bios-tables-test.c


as is, the next patch (5/6) should precede 3/6
yes, it is strange about patch order. How about split patch 3/6 into smaller patches, one patch for one test case, and move specified acpi table into smaller patches.

Regards
Bibo Mao



Signed-off-by: Bibo Mao <maob...@loongson.cn>
---
  tests/data/acpi/loongarch64/virt/APIC | 0
  tests/data/acpi/loongarch64/virt/DSDT | 0
  tests/data/acpi/loongarch64/virt/FACP | 0
  tests/data/acpi/loongarch64/virt/MCFG | 0
  tests/data/acpi/loongarch64/virt/PPTT | 0
  tests/data/acpi/loongarch64/virt/SLIT | 0
  tests/data/acpi/loongarch64/virt/SPCR | 0
  tests/data/acpi/loongarch64/virt/SRAT | 0
  8 files changed, 0 insertions(+), 0 deletions(-)
  create mode 100644 tests/data/acpi/loongarch64/virt/APIC
  create mode 100644 tests/data/acpi/loongarch64/virt/DSDT
  create mode 100644 tests/data/acpi/loongarch64/virt/FACP
  create mode 100644 tests/data/acpi/loongarch64/virt/MCFG
  create mode 100644 tests/data/acpi/loongarch64/virt/PPTT
  create mode 100644 tests/data/acpi/loongarch64/virt/SLIT
  create mode 100644 tests/data/acpi/loongarch64/virt/SPCR
  create mode 100644 tests/data/acpi/loongarch64/virt/SRAT

diff --git a/tests/data/acpi/loongarch64/virt/APIC 
b/tests/data/acpi/loongarch64/virt/APIC
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/DSDT 
b/tests/data/acpi/loongarch64/virt/DSDT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/FACP 
b/tests/data/acpi/loongarch64/virt/FACP
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/MCFG 
b/tests/data/acpi/loongarch64/virt/MCFG
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/PPTT 
b/tests/data/acpi/loongarch64/virt/PPTT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SLIT 
b/tests/data/acpi/loongarch64/virt/SLIT
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SPCR 
b/tests/data/acpi/loongarch64/virt/SPCR
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/loongarch64/virt/SRAT 
b/tests/data/acpi/loongarch64/virt/SRAT
new file mode 100644
index 0000000000..e69de29bb2


Reply via email to