On Wed, 21 May 2025 at 16:38, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Wed, May 21, 2025 at 04:34:24PM +0100, Peter Maydell wrote: > > Also, mjt's packaging for Debian puts in some stubs for the > > offending getwpuid etc functions, which suppress the glib warnings > > (this is why he noticed this whereas none of the rest of us did): > > > > https://sources.debian.org/patches/qemu/1:10.0.0%2Bds-2/static-linux-user-stubs.diff/ > > Oh interesting, I was conincidentally wondering if adding dummy > stubs might suppress this.
If we do I think that g_assert_not_reached() is probably better than returning -1 etc. > How about we pull that change upstream, and expand it to getaddrinfo > too ? I like the stubs much more than artificially splitting up > the source files The stub is still effectively a runtime assert. Splitting the source file gives us a compile time guarantee that we don't call the function, so I prefer that. thanks -- PMM
