Re: [PATCH v3 3/5] hw/arm/aspeed_ast27x0-fc: Map ca35 memory into system memory

[Cédric Le Goater]

On 5/22/25 05:36, Steven Lee wrote:

Map the CA35 memory region as a subregion of system_memory to ensure
a valid FlatView. This prevents failures in APIs that rely on the
global memory view, such as rom_check_and_register_reset().

Signed-off-by: Steven Lee <steven_...@aspeedtech.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  hw/arm/aspeed_ast27x0-fc.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
index f8cb632bca..7087be4288 100644
--- a/hw/arm/aspeed_ast27x0-fc.c
+++ b/hw/arm/aspeed_ast27x0-fc.c
@@ -68,6 +68,7 @@ static void ast2700fc_ca35_init(MachineState *machine)

memory_region_init(&s->ca35_memory, OBJECT(&s->ca35), "ca35-memory",

                         UINT64_MAX);
+    memory_region_add_subregion(get_system_memory(), 0, &s->ca35_memory);

if (!memory_region_init_ram(&s->ca35_dram, OBJECT(&s->ca35), "ca35-dram",

                                  AST2700FC_BMC_RAM_SIZE, &error_abort)) {