On 2025/05/23 19:24, Paolo Abeni wrote:
On 5/23/25 9:39 AM, Akihiko Odaki wrote:
diff --git a/net/tap-linux.c b/net/tap-linux.c
index 22ec2f45d2..2df601551e 100644
--- a/net/tap-linux.c
+++ b/net/tap-linux.c
@@ -37,6 +37,14 @@
#define PATH_NET_TUN "/dev/net/tun" +#ifndef TUN_F_UDP_TUNNEL_GSO
+#define TUN_F_UDP_TUNNEL_GSO       0x080
+#endif
+
+#ifndef TUN_F_UDP_TUNNEL_GSO_CSUM
+#define TUN_F_UDP_TUNNEL_GSO_CSUM  0x100
+#endif
+

These should be added to net/tap-linux.h, which contains other UAPI
definitions.

But perhaps it may be better to refactor it to add the real header file
using scripts/update-linux-headers.sh. Such a refactoring can be done
before this series gets ready to merge and will make this series a bit
smaller.

I may be missing something, but I don't think such refactor will make
this series relevantly smaller?!? Also, it looks something quite
orthogonal to me.

I propose to just move the above definition in net/tap-linux.h, if possible.

You can get rid of this 8 lines and that's all. Just moving to net/tap-linux.h is also fine.

Regards,
Akihiko Odaki

Reply via email to