Hi Richard,
thanks for the feedback. For some reason only three of your replies made
it to my inbox, but I've seen them (on lore.kernel.org) and I will
incorporate it.
May 24, 2025 at 7:07 PM, Richard Henderson wrote:
> On 5/19/25 16:19, Julian Ganz wrote:
> > diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c
> > index 7d48643bb6..e9325319a7 100644
> > --- a/target/hppa/int_helper.c
> > +++ b/target/hppa/int_helper.c
> > <snip>
> > @@ -208,6 +210,48 @@ void hppa_cpu_do_interrupt(CPUState *cs)
> > env->iasq_f = 0;
> > env->iasq_b = 0;
> > > + switch (i) {
> > + case EXCP_HPMC:
> > + case EXCP_POWER_FAIL:
> > + case EXCP_RC:
> > + case EXCP_EXT_INTERRUPT:
> > + case EXCP_LPMC:
> > + case EXCP_PER_INTERRUPT:
> > + case EXCP_TOC:
> > + qemu_plugin_vcpu_exception_cb(cs, last_pc);
> >
> Interrupts. Why are these separate from default:?
Oh, right. That should have been interrupts. Thanks for catching that.
It's a crude attempt to make sure I covered all exception types
correctly. The default case handles unknown exceptions, which I _assume_
are interrupts triggered by some periphery (but i might be wrong about
that). I was afraid that the simple absence of a name from the list
below would be too error-prone in terms of long-term maintenance. I'm
not against removing this, though.
Regards,
Julian
