On Fri, May 23, 2025 at 02:06:42AM +0000, Zhijian Li (Fujitsu) wrote:
> 
> 
> On 22/05/2025 21:16, Peter Xu wrote:
> > I followed up with Dave's idea, but then added all entries into it, below.
> > 
> >    Status: postcopy-active
> >    Time (ms): total=40504, setup=14, down=145
> >    RAM info:
> >      Throughput (Mbps): 6102.65
> >      Sizes (KiB):        pagesize=4, total=16777992
> >      Transfers (KiB):    transferred=37673019, remain=2136404
> >        Channels (KiB):   precopy=3, multifd=26108780, postcopy=11563855
> >        Page Types:       normal=9394288, zero=600672
> >      Page Rates (pps):   transfer_rate=185875, dirty_rate=278378
> 
> 
> Regarding the "transfer_rate" and "dirty_rate" fields:
> Would it be clearer to drop the "_rate" suffix since the category header
> "Page Rates (pps)" already implies they are rate metrics?

I made it verbose to be clear while still suitable in a line.  I don't feel
strongly - I can drop them when proposing the patch, thanks.

-- 
Peter Xu


Reply via email to