On Thu, May 29, 2025 at 04:31:47PM -0400, Stefan Hajnoczi wrote:
> Commit 2e8e18c2e463 ("virtio-scsi: add iothread-vq-mapping parameter")
> removed the limitation that virtio-scsi devices must successfully set
> the AioContext on their BlockBackends. This was made possible thanks to
> the QEMU multi-queue block layer.
> 
> This change broke qemu-iotests 240, which checks that adding a
> virtio-scsi device with a drive that is already in another AioContext
> will fail.
> 
> Update the test to take the relaxed behavior into account. I considered
> removing this test case entirely, but the code coverage still seems
> valuable.
> 
> Fixes: 2e8e18c2e463 ("virtio-scsi: add iothread-vq-mapping parameter")
> Reported-by: Thomas Huth <th...@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
>  tests/qemu-iotests/240     | 2 --
>  tests/qemu-iotests/240.out | 4 +---
>  2 files changed, 1 insertion(+), 5 deletions(-)

This one has been annoying me - thanks!

Reviewed-by: Eric Blake <ebl...@redhat.com>
Tested-by: Eric Blake <ebl...@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org


Reply via email to