On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote:
> John Snow <js...@redhat.com> writes:
> 
> [...]
> 
> > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh
> > new file mode 100755
> > index 00000000000..2211b6c7f41
> > --- /dev/null
> > +++ b/python/tests/qapi-flake8.sh
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh -e
> > +# SPDX-License-Identifier: LGPL-2.1-or-later
> 
> Why not GPL-2.0-or-later?

Indeed, checkpatch.pl should be warning about this choice, and requesting
that it be explained in the commit message.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Reply via email to