Re: [PATCH] vfio/container: Fix vfio_listener_commit()

[Cédric Le Goater]

On 6/9/25 13:54, Zhenzhong Duan wrote:

It's wrong to call into listener_begin callback in vfio_listener_commit().
Currently this impacts vfio-user.

Fixes: d9b7d8b6993b ("vfio/container: pass listener_begin/commit callbacks")
Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>
---
  hw/vfio/listener.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
index 203ed0314e..735b5f21b7 100644
--- a/hw/vfio/listener.c
+++ b/hw/vfio/listener.c
@@ -437,7 +437,7 @@ static void vfio_listener_commit(MemoryListener *listener)
                                                   listener);
      void (*listener_commit)(VFIOContainerBase *bcontainer);

- listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_begin;

+    listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_commit;

if (listener_commit) {

          listener_commit(bcontainer);

Applied to vfio-next.

Thanks,

C.